Re: [head tinderbox] failure on powerpc/powerpc

Weongyo, et all,

On Wed, Mar 10, 2010 at 10:29 PM, FreeBSD Tinderbox
<tinderbox_at_freebsd.org> wrote:
> TB --- 2010-03-11 05:11:25 - tinderbox 2.6 running on freebsd-current.sentex.ca
> TB --- 2010-03-11 05:11:25 - starting HEAD tinderbox run for powerpc/powerpc
> TB --- 2010-03-11 05:11:25 - cleaning the object tree
> TB --- 2010-03-11 05:11:41 - cvsupping the source tree
> TB --- 2010-03-11 05:11:41 - /usr/bin/csup -z -r 3 -g -L 1 -h cvsup.sentex.ca /tinderbox/HEAD/powerpc/powerpc/supfile
> TB --- 2010-03-11 05:12:22 - building world
> TB --- 2010-03-11 05:12:22 - MAKEOBJDIRPREFIX=/obj
> TB --- 2010-03-11 05:12:22 - PATH=/usr/bin:/usr/sbin:/bin:/sbin
> TB --- 2010-03-11 05:12:22 - TARGET=powerpc
> TB --- 2010-03-11 05:12:22 - TARGET_ARCH=powerpc
> TB --- 2010-03-11 05:12:22 - TZ=UTC
> TB --- 2010-03-11 05:12:22 - __MAKE_CONF=/dev/null
> TB --- 2010-03-11 05:12:22 - cd /src
> TB --- 2010-03-11 05:12:22 - /usr/bin/make -B buildworld
>>>> World build started on Thu Mar 11 05:12:23 UTC 2010
>>>> Rebuilding the temporary build tree
>>>> stage 1.1: legacy release compatibility shims
>>>> stage 1.2: bootstrap tools
>>>> stage 2.1: cleaning up the object tree
>>>> stage 2.2: rebuilding the object tree
>>>> stage 2.3: build tools
>>>> stage 3: cross tools
>>>> stage 4.1: building includes
>>>> stage 4.2: building libraries
>>>> stage 4.3: make dependencies
>>>> stage 4.4: building everything
>>>> World build completed on Thu Mar 11 06:12:41 UTC 2010
> TB --- 2010-03-11 06:12:41 - generating LINT kernel config
> TB --- 2010-03-11 06:12:41 - cd /src/sys/powerpc/conf
> TB --- 2010-03-11 06:12:41 - /usr/bin/make -B LINT
> TB --- 2010-03-11 06:12:41 - building LINT kernel
> TB --- 2010-03-11 06:12:41 - MAKEOBJDIRPREFIX=/obj
> TB --- 2010-03-11 06:12:41 - PATH=/usr/bin:/usr/sbin:/bin:/sbin
> TB --- 2010-03-11 06:12:41 - TARGET=powerpc
> TB --- 2010-03-11 06:12:41 - TARGET_ARCH=powerpc
> TB --- 2010-03-11 06:12:41 - TZ=UTC
> TB --- 2010-03-11 06:12:41 - __MAKE_CONF=/dev/null
> TB --- 2010-03-11 06:12:41 - cd /src
> TB --- 2010-03-11 06:12:41 - /usr/bin/make -B buildkernel KERNCONF=LINT
>>>> Kernel build for LINT started on Thu Mar 11 06:12:41 UTC 2010
>>>> stage 1: configuring the kernel
>>>> stage 2.1: cleaning up the object tree
>>>> stage 2.2: rebuilding the object tree
>>>> stage 2.3: build tools
>>>> stage 3.1: making dependencies
>>>> stage 3.2: building everything
> [...]
> ===> siba_bwn (all)
> cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS -include /obj/powerpc/src/sys/LINT/opt_global.h -I. -I_at_ -I_at_/contrib/altq -finline-limit=15000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -mlongcall -fno-omit-frame-pointer -I/obj/powerpc/src/sys/LINT -msoft-float -mno-altivec -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c
> cc1: warnings being treated as errors
> /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c: In function 'siba_dma_translation':
> /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c:2035: warning: dereferencing 'void *' pointer
> /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c:2035: error: request for member 'sd_bus' in something not a structure or union
> /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c:2035: warning: dereferencing 'void *' pointer
> /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c:2035: error: request for member 'sd_bus' in something not a structure or union
> *** Error code 1
>
> Stop in /src/sys/modules/siba_bwn.
> *** Error code 1
>
> Stop in /src/sys/modules.
> *** Error code 1
>
> Stop in /obj/powerpc/src/sys/LINT.
> *** Error code 1
>
> Stop in /src.
> *** Error code 1
>
> Stop in /src.
> TB --- 2010-03-11 06:29:31 - WARNING: /usr/bin/make returned exit code  1
> TB --- 2010-03-11 06:29:31 - ERROR: failed to build lint kernel
> TB --- 2010-03-11 06:29:31 - 3629.47 user 614.12 system 4685.83 real

    Could someone please try this patch to see whether or not it fixes
the void* deref issue? I don't think it's style(9) correct, but it
might resolve the issue.
Thanks,
-Garrett

Index: siba_core.c
===================================================================
--- siba_core.c	(revision 204996)
+++ siba_core.c	(working copy)
_at__at_ -2032,9 +2032,9 _at__at_
 siba_dma_translation(device_t dev)
 {

-	KASSERT(device_get_ivars(dev)->sd_bus->siba_type == SIBA_TYPE_PCI,
-	    ("unsupported bustype %d\n",
-	     device_get_ivars(dev)->sd_bus->siba_type));
+	KASSERT(((struct siba_softc *) device_get_ivars(dev))->sd_bus->siba_type ==
+	    SIBA_TYPE_PCI, ("unsupported bustype %d\n",
+	    ((struct siba_softc*) device_get_ivars(dev))->sd_bus->siba_type));

 	return (SIBA_PCI_DMA);
 }