Re: [head tinderbox] failure on powerpc/powerpc

On Thu, Mar 11, 2010 at 09:10:35PM +1300, Andrew Thompson wrote:
> On Wed, Mar 10, 2010 at 10:48:27PM -0800, Garrett Cooper wrote:
> > Weongyo, et all,
> > 
> > On Wed, Mar 10, 2010 at 10:29 PM, FreeBSD Tinderbox
> > > /src/sys/modules/siba_bwn/../../dev/siba/siba_core.c:2035: error: request for member 'sd_bus' in something not a structure or union
> > > *** Error code 1
> > >
> > > Stop in /src/sys/modules/siba_bwn.
> > > *** Error code 1
> > >
> > > Stop in /src/sys/modules.
> > > *** Error code 1
> > >
> > > Stop in /obj/powerpc/src/sys/LINT.
> > > *** Error code 1
> > >
> > > Stop in /src.
> > > *** Error code 1
> > >
> > > Stop in /src.
> > > TB --- 2010-03-11 06:29:31 - WARNING: /usr/bin/make returned exit code ?1
> > > TB --- 2010-03-11 06:29:31 - ERROR: failed to build lint kernel
> > > TB --- 2010-03-11 06:29:31 - 3629.47 user 614.12 system 4685.83 real
> > 
> >     Could someone please try this patch to see whether or not it fixes
> > the void* deref issue? I don't think it's style(9) correct, but it
> > might resolve the issue.
> > Thanks,
> > -Garrett
> > 
> > Index: siba_core.c
> > ===================================================================
> > --- siba_core.c	(revision 204996)
> > +++ siba_core.c	(working copy)
> > _at__at_ -2032,9 +2032,9 _at__at_
> >  siba_dma_translation(device_t dev)
> >  {
> > 
> > -	KASSERT(device_get_ivars(dev)->sd_bus->siba_type == SIBA_TYPE_PCI,
> > -	    ("unsupported bustype %d\n",
> > -	     device_get_ivars(dev)->sd_bus->siba_type));
> > +	KASSERT(((struct siba_softc *) device_get_ivars(dev))->sd_bus->siba_type ==
> > +	    SIBA_TYPE_PCI, ("unsupported bustype %d\n",
> > +	    ((struct siba_softc*) device_get_ivars(dev))->sd_bus->siba_type));
> > 
> 
> It was all getting a bit unwieldy, I committed a more simple fix in
> r205003.

Thank you for fix and sorry for break build.

regards,
Weongyo Jeong