Re: HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32

From: Gary Jennejohn <gary.jennejohn_at_freenet.de>
Date: Fri, 12 Mar 2010 11:36:25 +0100
On Thu, 11 Mar 2010 20:24:57 -0800
Garrett Cooper <yanefbsd_at_gmail.com> wrote:

>     I can haz PR review then? Here's an easy one :)...
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=144644
> 

Looks OK to me except I don't like the
	if (something) {
		one-line-of-code();
	}
constructs, but according to style(9) these are sort-of OK, viz

     Closing and opening braces go on the same line as the else.  Braces that
     are not necessary may be left out.
                       ^^^^^^^^^^^^^^^
             if (test)
                     stmt;
             else if (bar) {
                     stmt;
                     stmt;
             } else
                     stmt;

Saved by the "may."

---
Gary Jennejohn (gj_at_)
Received on Fri Mar 12 2010 - 09:36:29 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:01 UTC