Re: [PATCH] newvers.sh

From: David O'Brien <obrien_at_FreeBSD.org>
Date: Mon, 15 Mar 2010 07:28:07 -0700
On Sat, Mar 13, 2010 at 09:13:03PM -0700, M. Warner Losh wrote:
> In message: <20100312171206.GA31761_at_dragon.NUXI.org>
>             "David O'Brien" <obrien_at_freebsd.org> writes:
> : * Simplify SRCDIR calculation by directly finding the kernel sources
> :   based directly on one of them.
> : Reviewed by: dhw
> :   This change does not increase the kernel build time.  It also continues
> :   to restrict the revision to just the kernel sources, and not the whole
> :   tree.
> : Timing tests by: dhw
> 
> <patch omitted>
> 
> I have a better simplification, I think, that works for me for each of
> the tests that I've done (both traditional and buildkernel builds).

I also have other simplifications.  But want to do this in stages,
least there be some corner case or misunderstanding by someone.

> Can you confirm this works for you and also comment on the change
> itself?  It is a bigger change, but results in a simpler (I think)
> newvers.sh.
> Comments?

I would prefer to do this in stages so things aren't misunderstood.
This patch is one of the key parts that shows I am not making the
'svnversion' run take longer, and that it does not cover more of
the tree than before.

-- 
-- David  (obrien_at_FreeBSD.org)
Received on Mon Mar 15 2010 - 13:28:15 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:01 UTC