Re: taskqueue_create() name parameter lieftime

From: John Baldwin <jhb_at_freebsd.org>
Date: Tue, 16 Nov 2010 08:27:11 -0500
On Tuesday, November 16, 2010 7:20:47 am Andriy Gapon wrote:
> 
> taskqueue_create() documentation never explicitly says this, but current
> taskqueue_create() implementation just stores a 'name' pointer parameter
> internally.  Thus it depends on the 'name' having a life time encompassing that of
> the taskqueue.
> I think that alternatively we could have copied the name (or a portion of it) into
> an internal buffer.
> I don't any argument for either approach, just curious which one looks more
> preferable from general (FreeBSD, kernel) programming practices point of view.

Hmm, in many other places we store a separate copy (e.g. all the interrupt
code uses separate MAXCOMLEN char arrays to hold names).  If that is easy to
do, that is probably the best approach.

-- 
John Baldwin
Received on Tue Nov 16 2010 - 12:29:34 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:09 UTC