Re: taskqueue_create() name parameter lieftime

On Friday, November 19, 2010 11:20:04 am Andriy Gapon wrote:
> on 16/11/2010 15:27 John Baldwin said the following:
> > On Tuesday, November 16, 2010 7:20:47 am Andriy Gapon wrote:
> >>
> >> taskqueue_create() documentation never explicitly says this, but current
> >> taskqueue_create() implementation just stores a 'name' pointer parameter
> >> internally.  Thus it depends on the 'name' having a life time encompassing that of
> >> the taskqueue.
> >> I think that alternatively we could have copied the name (or a portion of it) into
> >> an internal buffer.
> >> I don't any argument for either approach, just curious which one looks more
> >> preferable from general (FreeBSD, kernel) programming practices point of view.
> > 
> > Hmm, in many other places we store a separate copy (e.g. all the interrupt
> > code uses separate MAXCOMLEN char arrays to hold names).  If that is easy to
> > do, that is probably the best approach.
> 
> BTW, tq_name doesn't seem to be used anywhere at all.
> Perhaps just drop it?  But still could be useful in a debugger, though.

If it's not used anywhere I would just drop it.

-- 
John Baldwin