uma_zfree(NULL) is broken

From: <mdf_at_FreeBSD.org>
Date: Mon, 18 Oct 2010 13:59:17 -0700
There's explicit protection for free(NULL, M_FOO), but uma_zfree(zone,
NULL) will put NULL in the local bucket and then probably return it
later from a uma_zalloc call.  Obviously it's not a good idea to call
uma_zfree(9) on NULL, but in this case it's an easy mistake to make
when e.g. converting a set of malloc(9)/free(9) uses into uma(9).

So is the "right" thing to allow a uma_zfree(NULL) and silently
succeed, like for free(9)?  That would be my guess, but I'm open to
alternatives.

Thanks,
matthew
Received on Mon Oct 18 2010 - 18:59:19 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:08 UTC