Re: MAXCPU preparations

From: Julian Elischer <julian_at_freebsd.org>
Date: Mon, 27 Sep 2010 08:53:44 -0700
  On 9/27/10 8:26 AM, Sean Bruno wrote:
> Does this look like an appropriate modification to libmemstat?
>
> Sean
>
>
> ==== //depot/yahoo/ybsd_7/src/lib/libmemstat/memstat.h#4
> - /home/seanbru/ybsd_7/src/lib/libmemstat/memstat.h ====
> _at__at_ -28,12 +28,13 _at__at_
>
>   #ifndef _MEMSTAT_H_
>   #define        _MEMSTAT_H_
> +#include<sys/param.h>
>
>   /*
>    * Number of CPU slots in library-internal data structures.  This
> should be
>    * at least the value of MAXCPU from param.h.
>    */
> -#define        MEMSTAT_MAXCPU  64
> +#define        MEMSTAT_MAXCPU  MAXCPU /* defined in
> sys/${ARCH}/include/param.h */
>


wouldn't it be better to do a sysctlbyname() and use the real value 
for the system?

>   /*
>    * Amount of caller data to maintain for each caller data slot.
> Applications
>
>
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>
Received on Mon Sep 27 2010 - 13:53:06 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:07 UTC