Re: panic: share -> excl _at_r224632

From: Martin Matuska <mm_at_FreeBSD.org>
Date: Fri, 05 Aug 2011 10:43:32 +0200
Patch updated.

On 05.08.2011 10:26, Kostik Belousov wrote:
> On Fri, Aug 05, 2011 at 10:18:49AM +0200, Martin Matuska wrote:
>> I agree to Kostik's  approach, but I suggest implementing it in a
>> separate function and also use for the unmount() part.
>>
>> Please review attached patch.
> Since you are moving the fragment to a function, you may somewhat reduce
> the code duplication by moving at least free() and return to the end
> of function and jumping to it.
>
> Also, after more looking at this, I think now that the check for VI_DOOMED
> is not needed, due to relookup and comparision of vp and vp1.

-- 
Martin Matuska
FreeBSD committer
http://blog.vx.sk


Received on Fri Aug 05 2011 - 06:43:38 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:16 UTC