Re: recent commit causes lock up

On Fri Aug 12 11, Test Rat wrote:
> Alexander Best <arundel_at_freebsd.org> writes:
> 
> > hi there,
> >
> > running r224715 i'm having no problems what so ever. after upgrading my kernel
> > to r224784, i'm experiencing fatal lock ups, where only a hard reset will
> > resolve the problem.
> >
> > the lock up happend two times while running chromium with only a decent number
> > of tabs (~ 5). also the lock up occured only after ~ 5 minutes uptime and an
> > uptime of chromium of only ~ 2 minutes.
> >
> > i've now reverted my kernel back to r224715 and everything's working again.
> 
> Do you use x11/nvidia-driver? In r224778 fget(9) KPI changed which broke
> the port in src/nvidia_linux.c:linux_ioctl_nvidia(). It's probably only
> called when using linuxolator, e.g. flash plugin. Try below workaround.

thanks. i just tried your patch and indeed: the nvidia driver was causing the
freeze. that should teach me a lessing always to compile 3rd party kernel
modules in combination with installing a new kernel. ;)

> 
> %%
> --- src/nvidia_linux.c~
> +++ src/nvidia_linux.c
> _at__at_ -26,6 +26,8 _at__at_
>  #include "machine/../linux32/linux32_proto.h"
>  #endif
>  
> +#include <sys/capability.h>
> +
>  int linux_ioctl_nvidia(d_thread_t *, struct linux_ioctl_args *);
>  
>  int linux_ioctl_nvidia(
> _at__at_ -37,7 +39,7 _at__at_ int linux_ioctl_nvidia(
>      int error;
>      u_long cmd;
>  
> -    if ((error = fget(td, args->fd, &fp)) != 0)
> +    if ((error = fget(td, args->fd, CAP_IOCTL, &fp)) != 0)
>          return error;
>  
>      cmd = args->cmd;
> %%