[RFC] removing broken includes

From: Alexander Best <arundel_at_freebsd.org>
Date: Thu, 3 Feb 2011 22:12:57 +0000
hi everybody,

i've started to check the source for broken includes, such as the one fixed in
r218189. so far i've run through arch=amd64 and found only two broken includes,
which should be fixed by the attached patch. the commands i'm using are:

for target=buildkernel:
make SRCCONF=/dev/null __MAKE_CONF=/dev/null NO_WARNS= CWARNFLAGS="-w -Werror -Wmissing-include-dirs" buildkernel

for target=buildworld:[*]
make SRCCONF=/dev/null __MAKE_CONF=/dev/null WITHOUT_CDDL=true NO_WARNS= CWARNFLAGS="-w -Wmissing-include-dirs" buildworld

next up are the other archs. also i'll try to run both buildworld and
installworld with "CC=clang -v" and "CXX=clang++ -v". although clang turns
-Wmissing-include-dirs into a noop, using the -v flag one can still detect
broken (and even duplicate) includes. thanks to pluknet_at_ for the info.

cheers.
alex

[*] the reason i'm setting WITHOUT_CDDL=true is that my installed world was
compiled with that option. trying to buildworld with CDDL support thus fails.
also at first i was trying to use the same command for buildworld, as i used
for buildkernel. however it seems CWARNFLAGS gets set in some places, so gcc(1)
will also treat non -Wmissing-include-dirs warnings as errors.

-- 
a13x

Received on Thu Feb 03 2011 - 21:12:57 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:11 UTC