Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/

Den 05/01/2011 kl. 14.14 skrev Ulrich Spörlein:

> Hello folks,
> 
> Now that I'm fairly confident that the stability issues with your.org's
> VMs have been resolved, I'd like to point you to the new and improved,
> semi-weekly analyzer runs at
> 
>        http://scan.freebsd.your.org/freebsd-head/


I had a look at this again. There are over 9.000 reports so it's a bit overwhelming, but I suspect there's a lot of "collateral damage".

Ignoring contrib code for the moment, I decided to look at usr.sbin.pw from 2011-01-05. There's one report (http://scan.freebsd.your.org/freebsd-head/usr.sbin.pw/2011-01-05-amd64/report-KkilQ3.html#EndPath) which turns out to be a false positive:

* Step 6 calls cmdhelp() on line 168;
* cmdhelp() ends with "exit(EXIT_FAILURE);" on line 432 which I assume is exit(3) from libc
* The analyzer doesn't know that this function never returns and continues to flag a null dereference in step 8

What's the fix here?

I think the reports are an excellent way to get acquainted with FreeBSD code. Marking and fixing the false positives would make bug-hunting in the remaining reports more motivating :-)

Thanks,
Erik