Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/

From: John Baldwin <jhb_at_freebsd.org>
Date: Wed, 5 Jan 2011 09:34:49 -0500
On Wednesday, January 05, 2011 9:11:50 am Erik Cederstrand wrote:
> 
> Den 05/01/2011 kl. 14.56 skrev Erik Cederstrand:
> 
> > Ignoring contrib code for the moment, I decided to look at usr.sbin.pw
> > from 2011-01-05. There's one report (http://scan.freebsd.your.org/freebsd-head/usr.sbin.pw/2011-01-05-amd64/report-KkilQ3.html#EndPath)
> > which turns out to be a false positive:
> > 
> > * Step 6 calls cmdhelp() on line 168;
> > * cmdhelp() ends with "exit(EXIT_FAILURE);" on line 432 which I assume
> > is exit(3) from libc
> > * The analyzer doesn't know that this function never returns and
> > continues to flag a null dereference in step 8
> 
> The same is true of err(), verr(), errc(), verrc(), errx(), and verrx()
> which is also causing false positive reports. They ultimately call exit(3).

These are all marked as __dead2, so the compiler should "know" that these do
not return.

-- 
John Baldwin
Received on Wed Jan 05 2011 - 13:38:42 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:10 UTC