Re: [PATCH] Make top -P an interactive toggle

On Saturday, July 09, 2011 5:44:16 am Alexander Best wrote:
> On Sat Jul  9 11, Alexander Best wrote:
> > On Fri Jul  8 11, Alexander Best wrote:
> > > On Fri Jul  8 11, John Baldwin wrote:
> > > > This patch lets you use 'P' while top is running to toggle between per-CPU and
> > > > global CPU stats.
> > > 
> > > very cool. i always thought that being able to interactivly enable/disable
> > > per-cpu stats in top would be a useful feature. great to see this being
> > > implemented.
> > 
> > oh...and of course i tested your patch. ;) works great without any issues.
> 
> would it be possible to display a note when using 'P'? E.g. when pressing 'z'
> top informs the user with one of these messages:
> 
> "Displaying system idle process."
> 
> or
> 
> "Not displaying system idle process."
> 
> would be nice to have something similar when pressing the 'P' key. Maybe:
> 
> "Display per-cpu CPU usage statistics."
> 
> and
> 
> "Not display per-cpu CPU usage statistics."

Ok, I went with "Displaying per-CPU statistics" and
"Displaying global CPU statistics".

-- 
John Baldwin