On Mon, Jul 11, 2011 at 4:00 PM, Ali Mashtizadeh <mashtizadeh_at_gmail.com> wrote: > Maybe someone can setup something like reviewboard [1] for developers > to use. This may also help folks who want to keep abreast of the > current work in a particular subsystem or get involved into the > development process more. At my company we use reviews and it seems to > help the catch some bugs and help new engineers ramp up faster. > > [1] http://www.reviewboard.org/ FreeBSD development is completely open; anyone can sign up for the svn-src-* mailing list they are interested in, including svn-src-head_at_. Code reviews are plenty as well; just check the list archives for discussion of bugs, poor design choices and unintended effects. But most reviews are silent and after-the-fact by looking at the list mail. It's a system that seems to be working just fine for the FreeBSD project so far. This isn't a job for most anyone; it's a volunteer project and so anything that raises the barrier to getting work done for the project should be looked at with skepticism. Is there a specific deficit that you want to address? Thanks, matthew > On Mon, Jul 11, 2011 at 2:48 PM, Arnaud Lacombe <lacombar_at_gmail.com> wrote: >> Hi, >> >> On Mon, Jul 11, 2011 at 5:14 PM, Andriy Gapon <avg_at_freebsd.org> wrote: >>> on 11/07/2011 23:33 Arnaud Lacombe said the following: >>>> For the record, I would like to see enforced public review for _every_ >>>> patch *before* it is checked in, as a strong rule. gcc system is >>>> particularly interesting. But it is not likely to happen in FreeBSD >>>> where FreeBSD committers are clearly more free than other at >>>> checking-in un-publicly-reviewed stuff (especially _bad_ stuff). >>>> >>>> This would of course apply even to long-time committers, no matter how >>>> it hurt their ego (which I definitively do not care about). >>> >>> Have you just volunteered to review all of the patches that I would like to >>> commit? And are you prepared to take responsibility for quality of your reviews? >>> I am sure that other developers will gladly accept your offer too. >>> >> _No-one_ can do all the reviews, especially not me (on a purely >> technical level). ACK must come from subsystem maintainers. Having >> public review would allow the community review, which is now just not >> possible today. As about patches from the maintainer, they might be >> committed without his approval, but still sent for review. If a >> maintainer goes outside his area, he has to get approval from the >> other subsystem maintainer. >> >> - Arnaud >> _______________________________________________ >> freebsd-current_at_freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org" >> > _______________________________________________ > freebsd-current_at_freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org" >Received on Mon Jul 11 2011 - 21:36:20 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:15 UTC