Re: virtualbox-ose 4.0.8 fails

On Monday 27 June 2011 03:42 pm, Bernhard Froehlich wrote:
> On Mon, 27 Jun 2011 11:40:31 -0400, Jung-uk Kim wrote:
> > On Saturday 25 June 2011 10:28 am, Bernhard Froehlich wrote:
> >> On Fri, 24 Jun 2011 16:11:27 -0400, Jung-uk Kim wrote:
> >> > On Friday 24 June 2011 02:58 pm, George Kontostanos wrote:
> >> >> On Fri, Jun 24, 2011 at 9:51 PM, Jung-uk Kim
> >> >> <jkim_at_freebsd.org>
> >> >
> >> > wrote:
> >> >> >> Any ideas regarding the virtualbox itself ?
> >> >> >
> >> >> > I am rebuilding world/kernel now. �After that, I'll rebuild
> >> >> > virtualbox-ose and try to fix it unless someone beat me to
> >> >> > it.
> >> >> >
> >> >> > :-)
> >> >> >
> >> >> > Jung-uk Kim
> >> >>
> >> >> Brilliant !!!
> >> >
> >> > Please try this patch:
> >> >
> >> > http://people.freebsd.org/~jkim/patch-src-VBox-Main-src-server
> >> >-fr eebsd-HostHardwareFreeBSD.cpp
> >> >
> >> > Just drop this in ports/emulators/virtualbox-ose/files and
> >> > rebuild.
> >>
> >> Thanks a lot, they look good. Do you agree that those two
> >> patches are licensed under MIT License so that i can push them
> >> upstream?
> >
> > Yes, of course.  Please feel free.
>
> Shouldn't the changes only be done for __FreeBSD_version >= 900038
> ? It's also not fully correct because the version wasn't bumped for
> the CAM changes but it's the best we can get.
>
> The same is true for the cpuset_t change but the version wasn't
> bumped either.
>
> http://svnweb.freebsd.org/base?view=revision&revision=223081
> http://svnweb.freebsd.org/base?view=revision&revision=222813

To be absolutely correct, yes, we need to bump __FreeBSD_version 
first.  However, it is very close to feature freeze and I don't think 
anybody wants to do that ATM.  For -CURRENT, I don't think it really 
matters as I said earlier:

http://docs.freebsd.org/cgi/mid.cgi?201106241352.14262.jkim

Now, are you going to "fix" __FreeBSD_version >= 700000 in these 
files, too? ;-)

Jung-uk Kim