Re: COUNT_IPIS vs CPU_FOREACH

From: Andriy Gapon <avg_at_FreeBSD.org>
Date: Tue, 10 May 2011 13:00:11 +0300
on 09/05/2011 16:35 John Baldwin said the following:
> On Saturday, May 07, 2011 5:37:26 am Andriy Gapon wrote:
>>
>> I believe that the following change is needed to fix COUNT_IPIS option.
>> Right now it seems to be a noop.
>>
>>
>>     mp_ipi_intrcnt: CPU_FOREACH can't be used this early
>>
>>     ... because all_cpus is not set yet.
> 
> Have you tested this?
> 
> all_cpus is set by start_all_aps() from cpu_mp_start() which runs at 
> SI_SUB_CPU.   This SYSINIT runs later at SI_SUB_INTR.
> 
> So I think CPU_FOREACH() should be fine here.

I think that you are right, it seems that I've screwed up my original
(pre-patch) testing - installed my experimental kernel to a wrong place.

-- 
Andriy Gapon
Received on Tue May 10 2011 - 08:00:15 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:14 UTC