Re: [PATCH] Toggle display of the kernel idle process (per-CPU idle threads) in top

On Fri May 27 11, Sergey Kandaurov wrote:
> On 27 May 2011 18:46, John Baldwin <jhb_at_freebsd.org> wrote:
> > Some times in top, I don't want to see all the per-CPU idle threads but
> > instead focus on the non-idle threads that are running.  Especially on a
> > system with a lot of CPUs, the idle threads can push all the interesting
> > threads off of the list.  This patch adds a new 'z' flag (gratuitously chosen
> > letter) and interactive command to toggle the display of the system idle
> > process.  Patch is tested against 8, but should work fine on HEAD too:
> 
> Works on HEAD as well. I like this idea.

works well for me, too. another thing i'd love to see is the -P flag becomming
interactive. also i think the -H option should really be documented along with
the other flags. i've seen quite a lot of people not finding the right section.
documenting a flag after the BUGS section is really non intuitive, no matter,
if the -H flag is freebsd specific or not. it should really be added to the
OPTIONS and INTERACTIVE MODE sections.

cheers.
alex

> Perhaps it could be combined with i key?
> 
> > _at__at_ -1075,7 +1081,13 _at__at_
> >                                reset_display();
> >                                putchar('\r');
> >                                break;
> > -
> > +                           case CMD_kidletog:
> > +                               ps.kidle = !ps.kidle;
> > +                               new_message(MT_standout | MT_delayed,
> > +                                   " %sisplaying kernel idle process.",
> 
> > +                                   ps.idle ? "D" : "Not d");
> ^^
> typo: s/idle/kidle/
> 
> 
> -- 
> wbr,
> pluknet

-- 
a13x