Re: [rfc] remove hlt_cpus et al sysctls and related code

From: Andriy Gapon <avg_at_FreeBSD.org>
Date: Tue, 31 May 2011 14:42:19 +0300
on 29/05/2011 06:06 Attilio Rao said the following:
> 2011/5/28 Attilio Rao <attilio_at_freebsd.org>:
>> 2011/5/25 Andriy Gapon <avg_at_freebsd.org>:
>>> The patch is here:
>>> http://people.freebsd.org/~avg/cpu-offline-sysctl.diff
>>> It should implement the strategy described above.
>>>
>>
>> I don't see the point in keeping alive mp_grab_cpu_hlt() and
>> supporting, actually.
>>
>> On the top of your patch I made some modifies that use directly
>> ap_watchdog() in cpu_idle() which I think is better for the time
>> being:
>> http://www.freebsd.org/~attilio/avg_rem_cpuhlt.diff

Yes, I agree, thank you.

>> If you are happy with it, just commit as long as Garrett tests that.


OK.  Waiting for test feedback.

>> On a second round of changes we can discuss mp_watchdog and eventual
>> removal / improvements to it.
> 
> I almost forgot: this change would also require an UPDATE entry, where
> you explicitly mention the "new" way to deal with CPUs. Use your
> prefer wording.

Sure.  Thank you!

BTW, I guess there would be no reason to MFC this change?

-- 
Andriy Gapon
Received on Tue May 31 2011 - 09:42:22 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:14 UTC