Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

From: Kostik Belousov <kostikbel_at_gmail.com>
Date: Sat, 5 Nov 2011 17:15:31 +0200
On Sat, Nov 05, 2011 at 07:37:48AM -0700, mdf_at_freebsd.org wrote:
> On Sat, Nov 5, 2011 at 7:13 AM, Kostik Belousov <kostikbel_at_gmail.com> wrote:
> > On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote:
> >
> > Below is the KBI patch after vm_page_bits_t merge is done.
> > Again, I did not spent time converting all in-tree consumers
> > from the (potentially) loadable modules to the new KPI until it
> > is agreed upon.
> 
> I like my bikeshed orange...
> 
> I would think a more canonical name would be get/set rather than
> read/write, especially since these operations aren't reading and
> writing the page (neither are they getting the page, but at least set
> is pretty unambiguous).
Look at the vm_page.h:385. vm_page_set_valid() is already taken.

Received on Sat Nov 05 2011 - 14:15:36 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:20 UTC