Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

From: Arnaud Lacombe <lacombar_at_gmail.com>
Date: Mon, 7 Nov 2011 14:37:26 -0500
Hi,

On Mon, Nov 7, 2011 at 2:03 PM, Arnaud Lacombe <lacombar_at_gmail.com> wrote:
> On Mon, Nov 7, 2011 at 4:36 AM, Attilio Rao <attilio_at_freebsd.org> wrote:
>> I'm unsure if this replies to your concerns because you just criticize
>> without making a real technical question in this post.
>>
> I made comments on 3 points:
>  - using internal implementation details of mutex(9) is broken
>  - LOCK_FILE/LOCK_LINE are broken (a bit of a divergence on the
> original subject :/)
>  - there is _no_ reason not to use inlines function for such trivial oneliners
>
ok, I read the original thread, now that I understand the purpose of
the patch. It would make the third comment irrelevant, but I still do
not agree about the reason of the patch.

 - ARnaud
Received on Mon Nov 07 2011 - 18:37:28 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:20 UTC