Re: config(8) does not add post-processing for source file with compile-with command in sys/conf/files

From: Ryan Stone <rysto32_at_gmail.com>
Date: Tue, 8 Nov 2011 20:51:41 -0500
On Tue, Oct 18, 2011 at 10:21 PM, Paul Ambrose <ambrosehua_at_gmail.com> wrote:
> when I digged the a PR(bin/160275), I found in_proto.c and
> if_ethersubr.c ( see sys/conf/files ) does not get
> ${NORMAL_CTFCONVERT} post-processing in Makefile
> (/usr/obj/usr/src/sys/MYKERNEL/Makefile) generated by config(8), so
> the objs does not contain ctf section

Here's a second attempt at this one.  I think that this version is
much cleaner than the other options in this thread.  If it survives a
make universe I intend to commit this:

Index: usr.sbin/config/mkmakefile.c
===================================================================
--- usr.sbin/config/mkmakefile.c        (revision 227341)
+++ usr.sbin/config/mkmakefile.c        (working copy)
_at__at_ -762,16 +762,21 _at__at_
                                break;
                        }
                        snprintf(cmd, sizeof(cmd),
-                           "${%s_%c%s}\n\t_at_${NORMAL_CTFCONVERT}", ftype,
+                           "${%s_%c%s}\n", ftype,
                            toupper(och),
                            ftp->f_flags & NOWERROR ? "_NOWERROR" : "");
                        compilewith = cmd;
                }
                *cp = och;
                if (strlen(ftp->f_objprefix))
-                       fprintf(f, "\t%s $S/%s\n\n", compilewith, np);
+                       fprintf(f, "\t%s $S/%s\n", compilewith, np);
                else
-                       fprintf(f, "\t%s\n\n", compilewith);
+                       fprintf(f, "\t%s\n", compilewith);
+
+               if (!(ftp->f_flags & NO_OBJ))
+                       fprintf(f, "\t_at_${NORMAL_CTFCONVERT}\n\n");
+               else
+                       fprintf(f, "\n");
        }
 }
Received on Wed Nov 09 2011 - 00:51:42 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:20 UTC