Re: st_dev and st_ino for pipes

From: John Baldwin <jhb_at_freebsd.org>
Date: Wed, 5 Oct 2011 08:29:10 -0400
On Sunday, October 02, 2011 6:04:05 pm Kostik Belousov wrote:
> Our implementation of pipes does not provide useful values for st_dev
> and st_ino when stat(2) is done on an anonymous pipe. It was noted by the
> people outside the project, e.g. Perl contains a workaround in one
> of its modules, submitted by Debian/kFreeBSD developers, see
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537555
> and the commit 16f708c9bc0dc48713b200 in the Perl git.
> 
> I think this is a non-conformance, since SUSv4 explicitely states
> in the description of stat(2)
> "For all other file types defined in this volume of POSIX.1-2008, the
> structure members st_mode, st_ino, st_dev, st_uid, st_gid, st_atim,
> st_ctim, and st_mtim shall have meaningful values ...".
> 
> Patch below implements the requirement, by the cost of the small overhead
> at the pipe creation time, and slightly bigger cost at the destruction.
> 
> Any comments ?

I think this is fine.

-- 
John Baldwin
Received on Wed Oct 05 2011 - 10:33:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:18 UTC