Re: [head tinderbox] failure on powerpc/powerpc

On Wed Oct  5 11, Alexander Best wrote:
> On Wed Oct  5 11, FreeBSD Tinderbox wrote:
> > TB --- 2011-10-05 12:55:29 - tinderbox 2.8 running on freebsd-current.sentex.ca
> > TB --- 2011-10-05 12:55:29 - starting HEAD tinderbox run for powerpc/powerpc
> > TB --- 2011-10-05 12:55:29 - cleaning the object tree
> > TB --- 2011-10-05 12:55:43 - cvsupping the source tree
> > TB --- 2011-10-05 12:55:43 - /usr/bin/csup -z -r 3 -g -L 1 -h cvsup.sentex.ca /tinderbox/HEAD/powerpc/powerpc/supfile
> > TB --- 2011-10-05 12:55:55 - building world
> > TB --- 2011-10-05 12:55:55 - CROSS_BUILD_TESTING=YES
> > TB --- 2011-10-05 12:55:55 - MAKEOBJDIRPREFIX=/obj
> > TB --- 2011-10-05 12:55:55 - PATH=/usr/bin:/usr/sbin:/bin:/sbin
> > TB --- 2011-10-05 12:55:55 - SRCCONF=/dev/null
> > TB --- 2011-10-05 12:55:55 - TARGET=powerpc
> > TB --- 2011-10-05 12:55:55 - TARGET_ARCH=powerpc
> > TB --- 2011-10-05 12:55:55 - TZ=UTC
> > TB --- 2011-10-05 12:55:55 - __MAKE_CONF=/dev/null
> > TB --- 2011-10-05 12:55:55 - cd /src
> > TB --- 2011-10-05 12:55:55 - /usr/bin/make -B buildworld
> > >>> World build started on Wed Oct  5 12:55:56 UTC 2011
> > >>> Rebuilding the temporary build tree
> > >>> stage 1.1: legacy release compatibility shims
> > >>> stage 1.2: bootstrap tools
> > >>> stage 2.1: cleaning up the object tree
> > >>> stage 2.2: rebuilding the object tree
> > >>> stage 2.3: build tools
> > >>> stage 3: cross tools
> > >>> stage 4.1: building includes
> > >>> stage 4.2: building libraries
> > >>> stage 4.3: make dependencies
> > >>> stage 4.4: building everything
> > [...]
> > cc -O2 -pipe  -I/src/usr.bin/grep/regex -I/usr/include/gnu -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /src/usr.bin/grep/util.c
> > cc -O2 -pipe  -I/src/usr.bin/grep/regex -I/usr/include/gnu -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /src/usr.bin/grep/regex/fastmatch.c
> > cc -O2 -pipe  -I/src/usr.bin/grep/regex -I/usr/include/gnu -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /src/usr.bin/grep/regex/hashtable.c
> > cc -O2 -pipe  -I/src/usr.bin/grep/regex -I/usr/include/gnu -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /src/usr.bin/grep/regex/tre-compile.c
> > cc -O2 -pipe  -I/src/usr.bin/grep/regex -I/usr/include/gnu -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /src/usr.bin/grep/regex/tre-fastmatch.c
> 
> [..] -Wno-unused-parameter [..] -Wunused-parameter ?

any thoughts about

diff --git a/share/mk/bsd.sys.mk b/share/mk/bsd.sys.mk
index 796d169..a6127bf 100644
--- a/share/mk/bsd.sys.mk
+++ b/share/mk/bsd.sys.mk
_at__at_ -36,12 +36,12 _at__at_ CWARNFLAGS  +=      -Werror
 CWARNFLAGS     +=      -Wall -Wno-format-y2k
 .  endif
 .  if ${WARNS} >= 3
-CWARNFLAGS     +=      -W -Wno-unused-parameter -Wstrict-prototypes\
+CWARNFLAGS     +=      -Wextra -Wstrict-prototypes\
                        -Wmissing-prototypes -Wpointer-arith
 .  endif
 .  if ${WARNS} >= 4
 CWARNFLAGS     +=      -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch\
-                       -Wshadow -Wunused-parameter
+                       -Wshadow
 .   if !defined(NO_WCAST_ALIGN)
 CWARNFLAGS     +=      -Wcast-align
 .   endif
_at__at_ -56,6 +56,9 _at__at_ CWARNFLAGS    +=      -Wchar-subscripts -Winline -Wnested-externs\
 # XXX always get it right.
 CWARNFLAGS     +=      -Wno-uninitialized
 .  endif
+.  if ${WARNS} == 3
+CWARNFLAGS     +=      -Wno-unused-parameter
+.  endif
 CWARNFLAGS     +=      -Wno-pointer-sign
 . endif
 
?

-Wunused-parameter seems to be enforced by -Wunsed, which seems to be implied
by -Wall. i also changed -W to the new name -Wextra.


> 
> cheers.
> alex
> 
> > cc1: warnings being treated as errors
> > /src/usr.bin/grep/regex/tre-fastmatch.c: In function 'tre_match_fast':
> > /src/usr.bin/grep/regex/tre-fastmatch.c:961: warning: comparison of unsigned expression < 0 is always false
> > *** Error code 1
> > 
> > Stop in /src/usr.bin/grep.
> > *** Error code 1
> > 
> > Stop in /src/usr.bin.
> > *** Error code 1
> > 
> > Stop in /src.
> > *** Error code 1
> > 
> > Stop in /src.
> > *** Error code 1
> > 
> > Stop in /src.
> > TB --- 2011-10-05 14:43:43 - WARNING: /usr/bin/make returned exit code  1 
> > TB --- 2011-10-05 14:43:43 - ERROR: failed to build world
> > TB --- 2011-10-05 14:43:43 - 5199.23 user 882.58 system 6494.23 real
> > 
> > 
> > http://tinderbox.freebsd.org/tinderbox-head-HEAD-powerpc-powerpc.full