Re: [RFC] FDT fix for 64 bit platforms

From: Nathan Whitehorn <nwhitehorn_at_freebsd.org>
Date: Fri, 14 Oct 2011 15:31:36 -0500
On 10/14/11 14:10, Jayachandran C. wrote:
> I'm planning commit this -CURRENT if there an no objections.
>
> In the current implementation, phandle is used to store a pointer to
> the location inside the device tree.  Since phandle_t is u32, this
> will not work on 64 bit platforms. With this fix, the phandle is the
> offset from the start of device tree pointer 'fdtp', which will be 32
> bit.
>
> Review or testing from device tree users will be welcome.
>
> JC.

Why not use offsets into the FDT rather than full pointers? I believe 
having phandles greater than 32 bits violates the FDT spec, and 
declaring that the FDT can't itself be larger than 4 GB seems reasonable.
-Nathan
Received on Fri Oct 14 2011 - 18:31:39 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:19 UTC