Re: make buildworld error on 9.0B2

On 29 September 2011 08:57, Greg Miller <greglmiller_at_gmail.com> wrote:
> On a fresh install of 9.0B2, I've updated my source to RELENG_9 with
> csup, and I get the following when I try to make buildworld:

Good, is this reproducable? There's a patch to csup that may help you
out with this.

Index: src/usr.bin/csup/fixups.c
===================================================================
--- src/usr.bin/csup/fixups.c   (revision 225772)
+++ src/usr.bin/csup/fixups.c   (working copy)
_at__at_ -141,7 +141,7 _at__at_
        fixups_lock(f);
        while (f->size == 0 && !f->closed)
                pthread_cond_wait(&f->cond, &f->lock);
-       if (f->closed) {
+       if (f->size == 0) {
                fixups_unlock(f);
                return (NULL);
        }

I know this is a bit of effort, but can you please reproduce the
issue, then see if this patch fixes it for you?
I'd like to try and get this into 9.0-RELEASE but there's no csup
maintainer so I'm just relying on "works for me" and code reviews from
others.

Thanks,

Adrian