Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0

From: Arnaud Lacombe <lacombar_at_gmail.com>
Date: Thu, 29 Sep 2011 20:01:11 -0400
Hi,

On Thu, Sep 29, 2011 at 6:20 PM, Craig Rodrigues <rodrigc_at_crodrigues.org> wrote:
> On Wed, Sep 28, 2011 at 1:15 AM, Jaakko Heinonen <jh_at_freebsd.org> wrote:
>>
>> I think that using the FEATURE() macro and feature_present(3) might be
>> more appropriate for this.
>>
>> Thanks.
>> --
>> Jaakko
>>
>
> Oh, OK.  I was unfamiliar with these API's because they are new in FreeBSD 8. :)
> How about the attached patch?

--- usr.sbin/burncd/burncd.c	(revision 225368)
+++ usr.sbin/burncd/burncd.c	(working copy)
_at__at_ -82,6 +82,15 _at__at_
 	int block_size = 0, block_type = 0, cdopen = 0, dvdrw = 0;
 	const char *dev, *env_speed;

+	if (feature_present("ata_cam")) {
+		printf("\nATA_CAM option is enabled in kernel.\n"
+		    "Install the sysutils/cdrtools port and use cdrecord "
+		    "instead.\n\n"
maybe could you avoid the line break here, this makes the sentence
un-grepable. You are breaking the 80-char limit anyway with the URL.

 - Arnaud

+		    "Please refer to:\n"
+		    "http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD\n");
+		exit(1);

>
> --
> Craig Rodrigues
> rodrigc_at_crodrigues.org
>
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"
>
Received on Thu Sep 29 2011 - 22:01:13 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:18 UTC