Re: Kernel builds, but crashes at boot (amd64, Revision: 234306)

On 04/17/12 10:49, Rainer Hurling wrote:
> Am 17.04.2012 03:53 (UTC+1) schrieb Edward Tomasz Napierała:
>> Wiadomość napisana przez Rainer Hurling w dniu 16 kwi 2012, o godz.
>> 19:58:
>>> On 16.04.2012 19:31 (UTC+1), Konstantin Belousov wrote:
>>>> On Mon, Apr 16, 2012 at 06:15:32PM +0200, Rainer Hurling wrote:
>>>>>
>>>>> I just updated my system to r234342, only downgraded
>>>>> /usr/src/sys/cam/scsi/scsi_da.c to r233746, and now the system is
>>>>> booting again. So obviously there is something wrong with the newest
>>>>> patch to  scsi_da.c.
>>>> It is too broad, try to revert exactly one patch and see whether it
>>>> works.
>>>
>>> Sorry for my bad english. I wanted to say, that I only reverted
>>> exactly one patch (file scsi_da.c from 234177 back to 233746
>>> manually). The rest is up to r234342.
>>
>> Could you try the patch below?
>>
>> Index: sys/cam/scsi/scsi_da.c
>> ===================================================================
>> --- sys/cam/scsi/scsi_da.c    (revision 234314)
>> +++ sys/cam/scsi/scsi_da.c    (working copy)
>> _at__at_ -938,7 +938,9 _at__at_ daopen(struct disk *dp)
>>       if (error != 0)
>>           xpt_print(periph->path, "unable to retrieve capacity data");
>>
>> -    if (periph->flags&  CAM_PERIPH_INVALID)
>> +    if (periph->flags&  CAM_PERIPH_INVALID ||
>> +        softc->disk->d_sectorsize == 0 ||
>> +        softc->disk->d_mediasize == 0)
>>           error = ENXIO;
>>
>>       if (error == 0&&  (softc->flags&  DA_FLAG_PACK_REMOVABLE) != 0&&
>>
>>
> 
> Thanks for the patch. I just tried it with 10.0-CURRENT (amd64) r234370
> and it at least boots again.

I tried this patch (thnak you). With patch, the problem with the
attached Dell HUB vanishes, the box does not dumps core.
But I didn't test without after I made world this morning, so my
statement is a little bit vague ..

Regards,
Oliver