Re: r234118 uart kernel module failure: "uart_cpu_eqres undefined"

On Friday, April 13, 2012 8:44:25 pm kwhite_at_site.uottawa.ca wrote:
> The change from sys/dev/uart/uart_cpu_{i386,amd64}.c to uart_cpu_x86.c
> probably also needs a corresponding change in the module Makefile.
> 
>         # kldload uart
>         link_elf: symbol uart_cpu_eqres undefined
> 
> Here's one suggestion that works for me:
> 
> Index: /sys/modules/uart/Makefile
> ===================================================================
> --- /sys/modules/uart/Makefile  (revision 234249)
> +++ /sys/modules/uart/Makefile  (working copy)
> _at__at_ -16,6 +16,8 _at__at_
>         uart_if.c uart_if.h uart_subr.c uart_tty.c
>  .if exists(${.CURDIR}/../../dev/uart/uart_cpu_${MACHINE}.c)
>  SRCS+= uart_cpu_${MACHINE}.c
> +.elif ${MACHINE} == "i386" || ${MACHINE} == "amd64"
> +SRCS+= uart_cpu_x86.c
>  .endif
>  SRCS+= bus_if.h card_if.h device_if.h isa_if.h ${ofw_bus_if} pci_if.h \
>         power_if.h pccarddevs.h serdev_if.h
> ------------------------------------------------------------------------

cc'ing Marcel (who made the uart(4) change).  I think this is correct, yes.

-- 
John Baldwin