Re: segfault in vfscanf(3): clang and __restrict usage

On 2012-04-25 21:13, Boris Samorodov wrote:
> 25.04.2012 22:57, Dimitry Andric пишет:
>> On 2012-04-24 21:49, Jean-Sébastien Pédron wrote:
>>> Hi everyone,
>>>
>>> vfscanf(3) in HEAD (r234606) segfaults when compiled with clang. For
>>> instance, here is a call made in cmake which crashes:
>>>     fscanf(f, "%*[^\n]\n");
>>
>> Using r234549 here, everything compiled with clang, but I cannot make
>> that statement crash, whatever I do.  Do you have a specific input file
>> which crashes it?
> 
> -----
> % uname -a
> FreeBSD bsam.wart.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r234635: Tue
> Apr 24 11:41:32 SAMT 2012     bsam_at_bsam.wart.ru:/usr/obj/usr/src/sys/BBX
>  i386
> % sudo gdb smartd smartd.core
> GNU gdb 6.1.1 [FreeBSD]
> [...]
> #0  0x33ebdc2e in vfscanf () from /lib/libc.so.7
> (gdb)
> -----
> 
> I think that cupsd also suffer from the bug.
> 
> BTW, I have the system and almost all ports compiled (tomorrow
> and today) with clang.

Looks like the __restricted keywords were introduced just two days ago,
in r234585, which may be why I didn't see any crashes yet.

I think the easiest solution for now is to #undef __restrict at the top
of both lib/libc/stdio/vfscanf.c and lib/libc/stdio/vfwscanf.c, then
recompile and reinstall libc.