Re: [PATCH] Add locking to twe(4) so it no longer uses Giant

From: John Baldwin <jhb_at_freebsd.org>
Date: Wed, 8 Aug 2012 07:27:45 -0400
On Tuesday, August 07, 2012 10:11:01 AM Mike Tancsa wrote:
> On 8/3/2012 5:26 PM, John Baldwin wrote:
> >> 	If there's a tool for poking at the drives/controller, I would use
> >> 	that, plus camcontrol. Of course you want a data intensive workload
> > 
> > (iometer/iozone/xdd with async and sync mode, random reads and sequential
> > reads, etc), and maybe resort to manual testing like pulling drives
> > (power, data) if you don't mind creating failures. If you have some
> > failed/failing drives kicking around, that would be a good test as well
> > (see that all/some of the failure paths are properly stimulated).
> > 
> > 3dm2 testing would be good for the ioctl handling, but the most critical
> > tests are basic I/O.
> 
> Looks like it breaks 3dm2 and the tw_cli.  With the patch, I am not able
> to see the 8006 controller I added.

Ugh, ok.  A few questions:

1) Does the driver see any attached drives/volumes?

2) If it does, does basic I/O to the drives work?

3) Can you add some debugging printfs to twe_ioctl() to see what, if anything,
   fails in that routine when tw_cli makes a request?

Thanks.

-- 
John Baldwin
Received on Wed Aug 08 2012 - 09:27:48 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:29 UTC