Re: sys/dev/amr build error with Clang

On Friday, August 31, 2012 5:13:01 am deeptech71_at_gmail.com wrote:
> Dimitry Andric wrote:
> > The one call to get the callout to amr_periodic() started seems to have
> > been commented out in r239912:
> >
> >    
http://svnweb.freebsd.org/base/head/sys/dev/amr/amr.c?r1=239912&r2=239911&pathrev=239912
> >
> > If the function isn't necessary anymore, it could just be deleted, or
> > #ifdef'd out.
> 
> I don't use "amr", so I personally don't care whether the use of the 
function was accidentally commented out or whether the function was 
accidentally left unused. But on a side-note, to a programmer not familiar 
with the driver, that case seems like a case of "the use was accidentally 
commented out".

No, read the diff more closely.  The call to timeout() to start the timer was
already commented out before.  That goes back to r65245 (12 years ago).  
Similar drivers don't use a periodic timer, so it can probably just be 
removed.  The reason for the new Clang warning is that the old timeout(9)
API passes the function pointer to untimeout(), whereas callout_stop() just
accepts a pointer to the callout structure.

-- 
John Baldwin