ixgbe(4) and SFP+ (un)supported module

Hi

I've just had this card installed in our servers:

ix0_at_pci0:12:0:0:        class=0x020000 card=0x7a118086 chip=0x10fb8086 rev=0x01 
hdr=0x00
    vendor     = 'Intel Corporation'
    device     = '82599EB 10-Gigabit SFI/SFP+ Network Connection'
    class      = network
    subclass   = ethernet
    cap 01[40] = powerspec 3  supports D0 D3  current D0
    cap 05[50] = MSI supports 1 message, 64 bit, vector masks 
    cap 11[70] = MSI-X supports 64 messages in map 0x20 enabled
    cap 10[a0] = PCI-Express 2 endpoint max data 512(512) FLR link x8(x8)
                 speed 2.5(5.0)
    cap 03[e0] = VPD
    ecap 0001[100] = AER 1 0 fatal 0 non-fatal 1 corrected
    ecap 0003[140] = Serial 1 90e2baffff2b92e8
    ecap 000e[150] = ARI 1
    ecap 0010[160] = SRIOV 1

Which yielded the following error initializing the driver:

ix0: <Intel(R) PRO/10GbE PCI-Express Network Driver, Version - 2.5.0> port 0xbcc
ix0: Using MSIX interrupts with 9 vectors
ix0: Unsupported SFP+ Module
device_attach: ix0 attach returned 5
ix0: <Intel(R) PRO/10GbE PCI-Express Network Driver, Version - 2.5.0> port 0xbce
ix0: Using MSIX interrupts with 9 vectors
ix0: Unsupported SFP+ Module
device_attach: ix0 attach returned 5
ix0: <Intel(R) PRO/10GbE PCI-Express Network Driver, Version - 2.5.0> port 0xbcc
ix0: Using MSIX interrupts with 9 vectors
ix0: Unsupported SFP+ Module
device_attach: ix0 attach returned 5
ix0: <Intel(R) PRO/10GbE PCI-Express Network Driver, Version - 2.5.0> port 0xbce
ix0: Using MSIX interrupts with 9 vectors
ix0: Unsupported SFP+ Module
device_attach: ix0 attach returned 5

The README in /usr/src/sys/dev/ixgbe claims that the module we have,
AFBR-703SDZ-IN is supported.  I had to make the following change
to get the driver to attach.  I get the feeling it's not the
correct fix however:

[firewall2.jnb1] /usr/src/sys/dev/ixgbe # svn diff
Index: ixgbe_phy.c
===================================================================
--- ixgbe_phy.c (revision 243808)
+++ ixgbe_phy.c (working copy)
_at__at_ -955,7 +955,7 _at__at_
        u8 oui_bytes[3] = {0, 0, 0};
        u8 cable_tech = 0;
        u8 cable_spec = 0;
-       u16 enforce_sfp = 0;
+       u16 enforce_sfp = 1;
 
        DEBUGFUNC("ixgbe_identify_sfp_module_generic");

Ian

-- 
Ian Freislich