Is UPS_PORT_POWER wrong?

From: Kohji Okuno <okuno.kohji_at_jp.panasonic.com>
Date: Mon, 23 Jan 2012 17:12:46 +0900 (JST)
Hi HPS,

I think that UPS_PORT_POWER and UPS_PORT_LINK_STATE overlap.
And, in xhci.c you set UPS_PORT_POWER as folows.

When UPS_PORT_POWER is set, UPS_PORT_LINK_STATE_GET() macro will
return incorrect value.

                if (v & XHCI_PS_PP) {
                        /*
                         * The USB 3.0 RH is using the
                         * USB 2.0's power bit
                         */
                        i |= UPS_PORT_POWER;
                }

Regards,
 Kohji Okuno
Received on Mon Jan 23 2012 - 07:12:49 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:23 UTC