Hi, On Sat, Jul 28, 2012 at 6:14 PM, Bjoern A. Zeeb <bzeeb-lists_at_lists.zabbadoz.net> wrote: > On Wed, 25 Jul 2012, Luigi Rizzo wrote: > >> During some ipfw/dummynet cleanup i noticed that the libkern version of >> inet_ntoa_r() is missing the buffer size argument that is present in >> the libc counterpart. >> >> Any objection if i fix it ? > > > And why exactly would you need it? What does libc do with it? Render > partial IPv4 addresses? > Mitigate possibilities of memory corruption ? At the very least, allow the following: { char tmp[sizeof "255.255.255.255"]; KASSERT(size >= (sizeof tmp)); [...] } to be enforced... but hey, who gives a damn about consistently doing things and enforcing code assumptions ? ;-) - Arnaud > -- > Bjoern A. Zeeb You have to have visions! > Stop bit received. Insert coin for new address family. > > _______________________________________________ > freebsd-current_at_freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe_at_freebsd.org"Received on Sat Jul 28 2012 - 20:35:41 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:29 UTC