On Sat, Jun 9, 2012 at 11:06 AM, Doug Barton <dougb_at_freebsd.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: RIPEMD160 > > On 06/09/2012 10:40, Matthew Seaman wrote: >> On 09/06/2012 18:26, Chris Rees wrote: >>> On 9 June 2012 18:15, Doug Barton <dougb_at_freebsd.org> wrote: >>>> I have recently tried the PORTS_MODULES knob, and found a >>>> problem. The ports tree searches for some dependencies by >>>> finding a binary in PATH, and that fails since by default >>>> /usr/local/ isn't there. The attached patch fixes that >>>> problem. >>>> >>>> It would be more robust to use PREFIX there instead of >>>> /usr/local explicitly, but I'm not sure how to unravel the mk >>>> maze to get that value. If anyone has a suggestion for that, >>>> I'd be happy to include it. >>> >>> As you mention, PREFIX is only defined in ports/Mk, and it'd >>> definitely be undesirable to be including any of those files :) >>> >>> The most robust (but unpleasant) solution would be one of the >>> following: >>> >>> PREFIX?=/usr/local PORTSMODULESENV=SYSDIR=${SYSDIR} >>> PATH=${PATH}:${PREFIX}/bin:${PREFIX}/sbin >>> >>> or the equivalent (and perhaps cleaner, not leaving PREFIX >>> defined) >>> >>> .if !defined(PREFIX) PORTSMODULESENV=SYSDIR=${SYSDIR} >>> PATH=${PATH}:/usr/local/bin:/usr/local/sbin .else >>> PORTSMODULESENV=SYSDIR=${SYSDIR} >>> PATH=${PATH}:${PREFIX}/bin:${PREFIX}/sbin .endif >>> >>> Both of these will respect make.conf's setting of PREFIX. >>> >> >> Shouldn't you be looking for LOCALBASE rather than PREFIX in this >> context? > > Both good points. New and improved attached. Looks like my patch, only with LOCALBASE being tunable and with with ${LOCALBASE}/sbin (in short I found a few different bugs from you a few months ago): http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161452 . Thanks! -GarrettReceived on Sat Jun 09 2012 - 17:02:14 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:27 UTC