Re: [PATCH] Trim some noise from the daily disk check

On Wed, Jun 20, 2012 at 09:35:27AM -0400, John Baldwin wrote:
> The daily periodic e-mails for my boxes always include useless output from 
> dump -W.  I think the daily e-mail should only do that if the sysadmin is 
> actually using dump.  The patch below skips the dump reporting it 
> /etc/dumpdates doesn't exist or exists and is an empty file (the latter is 
> what you get out-of-the-box):
> 
> Index: 400.status-disks
> ===================================================================
> --- 400.status-disks	(revision 237227)
> +++ 400.status-disks	(working copy)
> _at__at_ -19,13 +19,16 _at__at_ case "$daily_status_disks_enable" in
>  	df $daily_status_disks_df_flags && rc=1 || rc=3
>  
>  	# display which filesystems need backing up
> -	if ! [ -f /etc/fstab ]; then
> -		export PATH_FSTAB=/dev/null
> +	if [ -s /etc/dumpdates ]; then
> +		if ! [ -f /etc/fstab ]; then
> +			export PATH_FSTAB=/dev/null
> +		fi
> +
> +		echo ""
> +		dump W || rc=3
>  	fi
> +	;;
>  
> -	echo ""
> -	dump W || rc=3;;
> -
>      *)  rc=0;;
>  esac
>  
> Thoughts?

This seems sensible to me.

-- Brooks