Re: [RFT] llquantize for FreeBSD's dtrace

On Jun 26, 2012, at 15:06 , Fabian Keil wrote:

> Pedro Giffuni <pfg_at_freebsd.org> wrote:
> 
>> --- Mar 26/6/12, Mark Peek <mp_at_FreeBSD.org> ha scritto:
> 
>>> Try this, change the assert on line 1429 in file dt_cc.c
>>> from:
>>> 
>>> assert(!(arg & (UINT16_MAX << args[i].shift)));
>>> 
>>> to
>>> 
>>> assert(!(arg & ((uint64_t)UINT16_MAX <<
>>> args[i].shift)));
>>> 
>> 
>> This certainly looks correct. Thanks Mark !
>> 
>> I updated the patch:
>> 
>> http://people.freebsd.org/~pfg/patches/patch-dtrace-llquantize
> 
> Thanks a lot. Seems to work for me:
> 

And me as well.  I tested the example from the web site.

Nicely done!

Best,
George