Re: patches for if_iwi and wlan for WEP mode

From: Adrian Chadd <adrian_at_freebsd.org>
Date: Thu, 8 Mar 2012 09:51:02 -0800
On 8 March 2012 09:32, Mitsuru IWASAKI <iwasaki_at_jp.freebsd.org> wrote:
> Hi,
>
>> I'd rather you didn't commit iwi_update_mcast() unless you absolutely
>> know that the NIC doesn't need to be notified of multicast group
>> membership changes. If so, please commit that as a separate fix.
>
> OK, I'd do so.  I don't need mcast stuff for the time being,
> instead I'd check other area such as suspend/resume for the next target.
>
> Today's one at:
> http://people.freebsd.org/~iwasaki/iwi/iwi-20120308.diff
>
> # 2 lines fix, after all ;)

:-)

Thanks for this!

Once it's done, let's sort out the multicast stuff. Either we set
IFF_ALLMULTI as AK suggested or we figure out and write a proper
_update_mcast() function.

We can commit that as a separate patch.

I found my 2945 NIC btw, so hopefully I can get some test in on saturday.


Adrian
Received on Thu Mar 08 2012 - 16:51:02 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:24 UTC