[patch]: RFC changing order for khelp modules

From: Maksim Yevmenkin <maksim.yevmenkin_at_gmail.com>
Date: Thu, 3 May 2012 13:00:05 -0700
hello,

would anyone object to the following patch?

==

--- sys/module_khelp.h  (revision 582)
+++ sys/module_khelp.h  (working copy)
_at__at_ -83,7 +83,7 _at__at_
                .priv = &kmd_##hname                                    \
        };                                                              \
        DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN,   \
-           SI_ORDER_ANY);                                              \
+           SI_ORDER_MIDDLE);                                           \
        MODULE_VERSION(hname, version)

 #define        KHELP_DECLARE_MOD_UMA(hname, hdata, hhooks, version,
size, ctor, dtor) \
_at__at_ -102,7 +102,7 _at__at_
                .priv = &kmd_##hname                                    \
        };                                                              \
        DECLARE_MODULE(hname, h_##hname, SI_SUB_PROTO_IFATTACHDOMAIN,   \
-           SI_ORDER_ANY);                                              \
+           SI_ORDER_MIDDLE);                                           \
        MODULE_VERSION(hname, version)


==

the issue i stumbled upon is that when i compile in all available tcp
congestion control algorithms into the kernel (instead of using them
as modules) a couple of those fail to initialize and register because
they fail to find h_ertt khelp module (which is also complied in)

thanks,
max
Received on Thu May 03 2012 - 18:00:05 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:26 UTC