Re: wdog_kern_pat: liberate from SW_WATCHDOG

From: Attilio Rao <attilio_at_freebsd.org>
Date: Wed, 16 May 2012 14:02:20 +0100
2012/5/16, Andriy Gapon <avg_at_freebsd.org>:
> on 16/05/2012 15:37 Attilio Rao said the following:
>> 2012/5/16, Andriy Gapon <avg_at_freebsd.org>:
>>>
>>> I would like to commit something like the following patch.
>>> I think that in-kernel watchdog patting during crash dump is useful with
>>> hardware watchdogs too.  The code seems to work fine here.
>>> In fact, I am not sure why wdog_kern_pat was originally tied to
>>> SW_WATCHDOG.
>>
>> I didn't think I tested this with any hw watchdog.
>> Which one you are using for tests?
>
> amdsbwd and ichwd
>
>> BTW, can you please skip adding the white lines?
>
> I thought that those calls were quite significant to be emphasized by
> spacing.

I don't think this is the right thing to do style-wise. But it is up to you.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein
Received on Wed May 16 2012 - 11:02:22 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:27 UTC