Re: GCC update for testing

Hi Dimitry;

On 05/17/12 11:44, Dimitry Andric wrote:
> On 2012-05-17 17:44, Pedro Giffuni wrote:>  Hi;
>> I took a bunch of patches that were merged into the GCC 4.1 branch
>> (under GPLv2) and prepared a patch for merging them into our base
>> gcc. These are supposed to be bug fixes only.
>>
>> You can get the patch here:
>> http://people.freebsd.org/~pfg/patches/patch-contrib-gcc
>> And, for those really interested, the log is here:
>> http://people.freebsd.org/~pfg/patches/gcc41-pr-log
>>
>> It may be my imagination but the patch seems to be causing more
>> warnings than usual and it breaks the kernel here:
> ...
>> ../../../cam/scsi/scsi_sa.c: In function 'samount':
>> ../../../cam/scsi/scsi_sa.c:1887: warning: 'comp_supported' may be used
>> uninitialized in this function
>> ../../../cam/scsi/scsi_sa.c:1888: warning: 'write_protect' may be used
>> uninitialized in this function
> These warnings seem wrong, upon casual inspection of the code.  In any
> case, if you compile the same file with gcc 4.7, they don't appear. :)
>
> Any idea which particular gcc fix is responsible for them?
>
> As a workaround, we could set all those variable to some reasonable
> value, but that feels like a cheap trick to me...
>
> But I'd rather just not import the fix that causes those warnings.

I will have to dig deeper into the changes to see what causes this.
In any case I do agree and the patch will not be committed.
Ultimately I can just leave the list around and we bring them
in only as needed.

Pedro.