Re: 10-CURRENT r235646 && open-vm-tools-8.6.0-425873

On Saturday, May 26, 2012 10:22:29 am Matthias Apitz wrote:
> 
> Hi,
> 
> The port ports/emulators/open-vm-tools does not compile in 10-CURRENT:
> 
> # make install clean
> ...
> make VM_UNAME=10.0-CURRENT MV=mv RM=rm 
OVT_SOURCE_DIR=/usr/ports/emulators/open-vm-tools/work/open-vm-
tools-8.6.0-425873
> MODULEBUILDDIR=/usr/ports/emulators/open-vm-tools/work/open-vm-
tools-8.6.0-425873/modules/freebsd  -C "/usr/ports/emulators/open-vm-
tools/work/open-vm-tools-8.6.0-425873/modules/freebsd/vmxnet"
> _at_ -> /usr/src/sys
> machine -> /usr/src/sys/i386/include
> x86 -> /usr/src/sys/x86/include
> :> opt_bdg.h
> awk -f _at_/tools/makeobjops.awk _at_/kern/device_if.m -h
> awk -f _at_/tools/makeobjops.awk _at_/kern/bus_if.m -h
> awk -f _at_/tools/makeobjops.awk _at_/dev/pci/pci_if.m -h
> cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc  
-I/u
> sr/ports/emulators/open-vm-tools/work/open-vm-tools-8.6.0-425873/lib/include
> -I/usr/ports/emulators/open-vm-tools/work/open-vm-
tools-8.6.0-425873/modules/shared/vmxnet -I. -I_at_ -I_at_/contrib/altq -finline-
limit=8000 --param
> inline-unit-growth=100 --param large-function-growth=1000 -fno-common
> -mno-align-long-strings -mp
> referred-stack-boundary=2 -mno-mmx -mno-sse -msoft-float -ffreestanding
> -fstack-
> protector -std=iso9899:1999 -fstack-protector -Wall -Wredundant-decls
> -Wnested-e
> xterns -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith
> -Winline -Wcast
> -qual  -Wundef -Wno-pointer-sign -fformat-extensions
> -Wmissing-include-dirs -fd
> iagnostics-show-option   -c if_vxn.c
> cc1: warnings being treated as errors
> if_vxn.c: In function 'vxn_load_multicast':
> if_vxn.c:719: warning: implicit declaration of function 'IF_ADDR_LOCK'
> if_vxn.c:719: warning: nested extern declaration of 'IF_ADDR_LOCK'
> [-Wnested-ext erns]
> if_vxn.c:746: warning: implicit declaration of function 'IF_ADDR_UNLOCK'
> if_vxn.c:746: warning: nested extern declaration of 'IF_ADDR_UNLOCK'
> [-Wnested-e xterns]
> *** [if_vxn.o] Error code 1
> 
> Let me know if you need more information.
> Thanks

It should be using if_mcast_rlock() and if_mcast_runlock() instead of using 
those macros directly.  This works all the way back to 8.0.

-- 
John Baldwin