On Thu, Nov 15, 2012 at 8:38 PM, Andriy Gapon <avg_at_freebsd.org> wrote: > on 15/11/2012 20:46 Attilio Rao said the following: >> On 11/15/12, Andriy Gapon <avg_at_freebsd.org> wrote: >>> >>> To people knowing the code, >>> >>> do the following documentation changes look correct? >> >> The latter chunk is not correct. >> It will panic only if assertions are on. > > But the current content is not correct too? Indeed, current content is crappy. >> I was thinking that however >> it would be good idea to patch lockmgr to panic also in non-debugging >> kernel situation. > > It would make sense indeed, IMO. Do you think you can test this patch?: http://www.freebsd.org/~attilio/lockmgr_forcerec.patch I think the LK_NOSHARE case is still fine with just asserts. Once this patch goes in, you are free to commit your documentation one. Thanks for fixing doc. Attilio -- Peace can only be achieved by understanding - A. EinsteinReceived on Thu Nov 15 2012 - 20:44:46 UTC
This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:32 UTC