Re: Is this a typo in if_tap.c?

On 2012/11/22 17:39, David Xu wrote:
> When I was trying to create a second tap device, kernel crashed.
> Is this patch correct ?
>
>
> Index: sys/net/if_tap.c
> ===================================================================
> --- sys/net/if_tap.c    (revision 243397)
> +++ sys/net/if_tap.c    (working copy)
> _at__at_ -186,7 +186,7 _at__at_
>      /* Find any existing device, or allocate new unit number. */
>      i = clone_create(&tapclones, &tap_cdevsw, &unit, &dev, 0);
>      if (i) {
> -        dev = make_dev(&tap_cdevsw, 0, UID_ROOT, GID_WHEEL, 0600,
> +        dev = make_dev(&tap_cdevsw, unit, UID_ROOT, GID_WHEEL, 0600,
>              "%s%d", tapname, unit);
>      }
>

The patch looks right to me.

     Kevin