Re: [head tinderbox] failure on i386/i386

Hi,

----- Original Message -----
> From: "FreeBSD Tinderbox" <tinderbox_at_freebsd.org>
> To: "FreeBSD Tinderbox" <tinderbox_at_freebsd.org>, current_at_freebsd.org, i386_at_freebsd.org
> Sent: Friday, October 12, 2012 6:11:27 AM
> Subject: [head tinderbox] failure on i386/i386
> 
> TB --- 2012-10-12 04:50:01 - tinderbox 2.9 running on
> freebsd-current.sentex.ca
> TB --- 2012-10-12 04:50:01 - FreeBSD freebsd-current.sentex.ca
> 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT
> 2012     des_at_freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC
>  amd64
> TB --- 2012-10-12 04:50:01 - starting HEAD tinderbox run for
> i386/i386
> TB --- 2012-10-12 04:50:01 - cleaning the object tree
> TB --- 2012-10-12 04:50:01 - checking out /src from
> svn://svn.freebsd.org/base/head
> TB --- 2012-10-12 04:50:01 - cd /tinderbox/HEAD/i386/i386
> TB --- 2012-10-12 04:50:01 - /usr/local/bin/svn cleanup /src
> TB --- 2012-10-12 04:53:23 - /usr/local/bin/svn update /src
> TB --- 2012-10-12 04:53:42 - At svn revision 241478

[SNIP]

> TB --- 2012-10-12 10:54:26 - /usr/bin/make -B buildkernel
> KERNCONF=XEN
> >>> Kernel build for XEN started on Fri Oct 12 10:54:26 UTC 2012
> >>> stage 1: configuring the kernel
> >>> stage 2.1: cleaning up the object tree
> >>> stage 2.2: rebuilding the object tree
> >>> stage 2.3: build tools
> >>> stage 3.1: making dependencies
> >>> stage 3.2: building everything
> [...]
> objcopy --only-keep-debug virtio_balloon.ko.debug
> virtio_balloon.ko.symbols
> objcopy --strip-debug --add-gnu-debuglink=virtio_balloon.ko.symbols
> virtio_balloon.ko.debug virtio_balloon.ko
> ===> virtio/scsi (all)
> cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE
> -nostdinc   -DHAVE_KERNEL_OPTION_HEADERS -include
> /obj/i386.i386/src/sys/XEN/opt_global.h -I. -I_at_ -I_at_/contrib/altq
> -finline-limit=8000 --param inline-unit-growth=100 --param
> large-function-growth=1000 -fno-common -g
> -I/obj/i386.i386/src/sys/XEN  -mno-align-long-strings
> -mpreferred-stack-boundary=2 -mno-mmx -mno-sse -msoft-float
> -ffreestanding -fstack-protector -std=iso9899:1999 -fstack-protector
> -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes
>  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs
> -fdiagnostics-show-option   -c
> /src/sys/modules/virtio/scsi/../../../dev/virtio/scsi/virtio_scsi.c
> cc1: warnings being treated as errors
> /src/sys/modules/virtio/scsi/../../../dev/virtio/scsi/virtio_scsi.c:
> In function 'vtscsi_sg_append_scsi_buf':
> /src/sys/modules/virtio/scsi/../../../dev/virtio/scsi/virtio_scsi.c:974:
> warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
> /src/sys/modules/virtio/scsi/../../../dev/virtio/scsi/virtio_scsi.c:982:
> warning: cast to pointer from integer of different size
> [-Wint-to-pointer-cast]
> *** [virtio_scsi.o] Error code 1

I cannot seem to recreate this locally, but I think these need
to be casted through uintptr?

diff --git a/sys/dev/virtio/scsi/virtio_scsi.c b/sys/dev/virtio/scsi/virtio_scsi.c
index f2e1412..79bc988 100644
--- a/sys/dev/virtio/scsi/virtio_scsi.c
+++ b/sys/dev/virtio/scsi/virtio_scsi.c
_at__at_ -971,7 +971,7 _at__at_ vtscsi_sg_append_scsi_buf(struct vtscsi_softc *sc, struct sglist *sg,
                            csio->data_ptr, csio->dxfer_len);
                else
                        error = sglist_append_phys(sg,
-                           (vm_paddr_t) csio->data_ptr, csio->dxfer_len);
+                           (vm_paddr_t)(uintptr_t) csio->data_ptr, csio->dxfer_len);
        } else {
 
                for (i = 0; i < csio->sglist_cnt && error == 0; i++) {
_at__at_ -979,7 +979,7 _at__at_ vtscsi_sg_append_scsi_buf(struct vtscsi_softc *sc, struct sglist *sg,
 
                        if ((ccbh->flags & CAM_SG_LIST_PHYS) == 0)
                                error = sglist_append(sg,
-                                   (void *) dseg->ds_addr, dseg->ds_len);
+                                   (void *)(uintptr_t) dseg->ds_addr, dseg->ds_len);
                        else
                                error = sglist_append_phys(sg,
                                    (vm_paddr_t) dseg->ds_addr, dseg->ds_len);

That being said, compiling VirtIO for a XEN kernel probably
doesn't make any sense.

Bryan

> 
> Stop in /src/sys/modules/virtio/scsi.
> *** [all] Error code 1
> 
> Stop in /src/sys/modules/virtio.
> *** [all] Error code 1
> 
> Stop in /src/sys/modules.
> *** [modules-all] Error code 1
> 
> Stop in /obj/i386.i386/src/sys/XEN.
> *** [buildkernel] Error code 1
> 
> Stop in /src.
> *** Error code 1
> 
> Stop in /src.
> TB --- 2012-10-12 11:11:27 - WARNING: /usr/bin/make returned exit
> code  1
> TB --- 2012-10-12 11:11:27 - ERROR: failed to build XEN kernel
> TB --- 2012-10-12 11:11:27 - 17474.50 user 2374.09 system 22886.60
> real
> 
> 
> http://tinderbox.freebsd.org/tinderbox-head-HEAD-i386-i386.full
> _______________________________________________
> freebsd-current_at_freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to
> "freebsd-current-unsubscribe_at_freebsd.org"
>