Re: [PATCH] unbreak imake build when clang set as base compiler

From: Garrett Cooper <yanegomi_at_gmail.com>
Date: Wed, 26 Sep 2012 14:42:30 -0700
On Wed, Sep 26, 2012 at 2:18 PM, Oliver Pinter <oliver.pntr_at_gmail.com> wrote:
> On 9/26/12, Garrett Cooper <yanegomi_at_gmail.com> wrote:
>> On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter <oliver.pntr_at_gmail.com>
>> wrote:
>>> Hi all!
>>>
>>> This patch fixed the problem, when buildig imake on a machine where
>>> clang is the base the compiler (WITH_CLANG_IS_CC).
>>
>> (Picking a random message to reply to) Why not create PRs and CC the
>> relevant parties?
>
> because I hope, there become this issue a mote attention ;)

Or gets lost in someone's mailbox :(...

> of course, I create in near future a PR, but before that, I send an
> updated patch, and yes, I know, that this is not a clean solution, but
> better than nothing.

Having a PR is better than a random email that will most likely get
lost. I would definitely respond to:

"Hey $dev! I filed $PR -- can you please take a look at it? It solves
'$reason'. Thanks!"

You might get better results this way too and less duplicated effort
by multiple individuals.. just sayin'...

Thanks!
-Garrett
Received on Wed Sep 26 2012 - 19:42:31 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:30 UTC