Re: [PATCH] unbreak imake build when clang set as base compiler

From: Oliver Pinter <oliver.pntr_at_gmail.com>
Date: Thu, 27 Sep 2012 00:31:13 +0200
On 9/27/12, Oliver Pinter <oliver.pntr_at_gmail.com> wrote:
> On 9/26/12, Garrett Cooper <yanegomi_at_gmail.com> wrote:
>> On Wed, Sep 26, 2012 at 2:18 PM, Oliver Pinter <oliver.pntr_at_gmail.com>
>> wrote:
>>> On 9/26/12, Garrett Cooper <yanegomi_at_gmail.com> wrote:
>>>> On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter <oliver.pntr_at_gmail.com>
>>>> wrote:
>>>>> Hi all!
>>>>>
>>>>> This patch fixed the problem, when buildig imake on a machine where
>>>>> clang is the base the compiler (WITH_CLANG_IS_CC).
>>>>
>>>> (Picking a random message to reply to) Why not create PRs and CC the
>>>> relevant parties?
>>>
>>> because I hope, there become this issue a mote attention ;)
>>
>> Or gets lost in someone's mailbox :(...
>>
>>> of course, I create in near future a PR, but before that, I send an
>>> updated patch, and yes, I know, that this is not a clean solution, but
>>> better than nothing.
>>
>> Having a PR is better than a random email that will most likely get
>> lost. I would definitely respond to:
>>
>> "Hey $dev! I filed $PR -- can you please take a look at it? It solves
>> '$reason'. Thanks!"
>
> ports/172103 ports/172104 ports/172102 ports/172101 ports/172100 ;)

and the patches are here too:
http://oliverp.teteny.bme.hu/freebsd/patches/ports-clang/

>
>>
>> You might get better results this way too and less duplicated effort
>> by multiple individuals.. just sayin'...
>>
>> Thanks!
>> -Garrett
>>
>
Received on Wed Sep 26 2012 - 20:31:14 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:30 UTC