Re: Proposal for change to kernel linker for fixing a VNET and DPCPU problem.

From: Mikolaj Golub <trociny_at_FreeBSD.org>
Date: Thu, 27 Sep 2012 18:01:06 +0300
On Tue, Sep 25, 2012 at 11:07:02AM -0400, John Baldwin wrote:
> On Friday, September 21, 2012 12:56:56 pm Julian Elischer wrote:
> > On 9/21/12 2:22 AM, Mikolaj Golub wrote:

> > > http://people.freebsd.org/~trociny/link_elf.c.pcpu_vnet.patch
> > >
> > > The fix is to make the linker on a module load recognize "external"
> > > VNET/DPCPU variables defined in the previously loaded modules and
> > > relocate them accordingly. For this set_pcpu_list and set_vnet_list
> > > are used, where the addresses of modules 'set_pcpu' and 'set_vnet'
> > > linker sets are stored in.
> > 
> > it makes sense to me, but I really am not a linker person..
> > I think it woul be good to get Doug Rabson  to weigh in on it, and
> > maybe john Baldwin..
> > 
> > moving to -current as it's not a "net" issue really..
> 
> I think the proposed patch is ok.

Thanks! Committed as r240997.

-- 
Mikolaj Golub
Received on Thu Sep 27 2012 - 13:01:12 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:30 UTC