Re: rc.subr: disabling globbing while processing devfs rules

From: Andriy Gapon <avg_at_FreeBSD.org>
Date: Mon, 01 Apr 2013 23:30:12 +0300
on 01/04/2013 23:16 John Baldwin said the following:
> On Monday, April 01, 2013 3:56:01 pm Jilles Tjoelker wrote:
>> On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote:
>>> Why not use 'local -' instead of the $- magic?  That is:
>>
>>> devfs_rulesets_from_file()
>>> {
>>>    local file _err _me -
>>>
>>>    ...
>>>    set -f
>>>    ...
>>> }
>>
>>> That would seem to be simpler.
>>
>> I had mentioned this possibility on IRC, but this feature is specific to
>> Almquist-derived shells (ash) and so something more portable was
>> selected. (It's still not standard because POSIX does not specify
>> "local" but it works on most shells in use.)
> 
> rc.subr isn't meant to be portable, it's a script that is part of the FreeBSD 
> base system.  I find the 'local -' syntax more readable (and used the feature 
> quite a bit in etcupdate).
> 

You have to set an example in etc/ :-)
I used a script in etc/rc.d as a starting point, Jilles guided me from there.

-- 
Andriy Gapon
Received on Mon Apr 01 2013 - 18:30:18 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:36 UTC